On 4/22/22 05:25, Giovanni Mascellani wrote: > +static void initialize_var_from_initializer(struct hlsl_ctx *ctx, struct hlsl_ir_var *var, > struct parse_initializer *initializer) > { As long as you're resending anyway, I'd advocate for just inlining this function into its caller.