[PATCH vkd3d v3 09/11] vkd3d-shader/hlsl: Support all complex initalizers.

Zebediah Figura zfigura at codeweavers.com
Fri Apr 22 17:24:40 CDT 2022


On 4/22/22 16:51, Francisco Casas wrote:
> April 22, 2022 3:57 PM, "Zebediah Figura" <zfigura at codeweavers.com> wrote:
> 
>> On 4/22/22 05:25, Giovanni Mascellani wrote:
>>
>>> +static void initialize_var_from_initializer(struct hlsl_ctx *ctx, struct hlsl_ir_var *var,
>>> struct parse_initializer *initializer)
>>> {
>>
>> As long as you're resending anyway, I'd advocate for just inlining this function into its caller.
> 
> Okay, the function is used in latter patches but I agree it is short enough to be inlined when
> needed.
> 

I guess if it's used later, it's fine keeping it separate.



More information about the wine-devel mailing list