[PATCH 1/2] mshtmlmedia: Add dll.
Alexandre Julliard
julliard at winehq.org
Sun Apr 24 07:43:48 CDT 2022
Austin English <austinenglish at gmail.com> writes:
> On Sun, Apr 24, 2022 at 5:26 AM Alexandre Julliard <julliard at winehq.org> wrote:
>
> Austin English <austinenglish at gmail.com> writes:
>
> > At the same time, I agree of course that just the contributor's desire
> > to work on something is enough to consider submitted work. For this
> > patch what kind of feedback would you expect?
> >
> > I think the feedback/review, in general, has been fair/valid. I am
> > disagreeing in how explicit Wine is being, as a project, for testing
> > patches before submitting upstream.
>
> The issue is not testing the patch, it's demonstrating that there's a
> need for it in the first place.
>
> Can we clarify what is needed to demonstrate that this patch is needed?
In the general case, pointing to a bug report showing an app running
into the problem on standard Wine is a good first step.
In this specific case, since it's not a Windows DLL but some internal IE
thing, it would additionally need a convincing explanation of why we
need the dll on Wine even though it's not present on most Windows
installs.
--
Alexandre Julliard
julliard at winehq.org
More information about the wine-devel
mailing list