[PATCH vkd3d 6/8] vkd3d-shader/hlsl: Use a more sensible source location in add_constructor().
Zebediah Figura
zfigura at codeweavers.com
Thu Apr 28 13:21:38 CDT 2022
On 4/28/22 08:32, Giovanni Mascellani wrote:
> Signed-off-by: Giovanni Mascellani <gmascellani at codeweavers.com>
> ---
> libs/vkd3d-shader/hlsl.y | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/libs/vkd3d-shader/hlsl.y b/libs/vkd3d-shader/hlsl.y
> index 3fff8fc6..b68d9700 100644
> --- a/libs/vkd3d-shader/hlsl.y
> +++ b/libs/vkd3d-shader/hlsl.y
> @@ -2077,7 +2077,7 @@ static struct list *add_constructor(struct hlsl_ctx *ctx, struct hlsl_type *type
> continue;
> }
>
> - initialize_var_components(ctx, params->instrs, var, &idx, arg, &loc);
> + initialize_var_components(ctx, params->instrs, var, &idx, arg, &arg->loc);
> }
>
> if (!(load = hlsl_new_var_load(ctx, var, loc)))
Note that this makes the "loc" parameter to initialize_var_components()
redundant.
I think this patch makes sense, although do you happen to have an
example of an error message that's improved this way?
More information about the wine-devel
mailing list