[PATCH vkd3d 2/8] vkd3d-shader/hlsl: Rename replace_node() to hlsl_replace_node().

[Zebediah Figura (she/her)]

On 1/7/22 06:12, Francisco Casas wrote:
> January 7, 2022 6:19 AM, "Giovanni Mascellani" <gmascellani at codeweavers.com> wrote:
> 
>> Hi,
>>
>> I think that this patch should be squashed with 1/8. The idea is that the code should be "clean" at
>> all times, even between the patches of a single patch set, and my understanding is that being clean
>> includes having a "hlsl_" prefix for all the symbols in hlsl.h (this also applies to 3/8).
>>
>> Also, I think that renaming the function and moving it to another file are changes simple enough
>> that they can be merged in the same patch. But if you really prefer doing that in two patches, I'd
>> first change the name and then move.
>>
>> Giovanni.
>>
> 
> Okay!
> I have been told that's preferable to move something and change it on different patches,
> but maybe that is when the changes are more than just changing the name.
> 

The point is to make it clear what actually changed; if you move 
something and change it at the same time it's not obvious from the diff.

In a case like this it's fine to do it at the same time (and probably 
preferable).