[PATCH] adsldp/tests: Fix misleading indentation warnings

Dmitry Timoshkov dmitry at baikal.ru
Sun Jan 23 13:32:18 CST 2022


Fabian Maurer <dark.shadow4 at web.de> wrote:

> I know they're intentionally formatted like that. But it causes a lot of
> compile warning, or errors when using -Werror.
> I don't think it should be that using todo_wine causes compile warnings.
> Sure, in a perfect world we'd never need todo_wine, but we're not in a perfect
> world and I want to avoid compile warnings.

Probably the compiler shouldn't emit this kind of warnings, and disabling
the warning is another option, perhaps just in a local build if this kind
of warnings bothers too much.

> Alternative would be to manually add curly braces, this would make the
> compiler happy as well. But fixing the indentation seems more logical to me.

More logical seems fixing the place a todo_wine was added for.

-- 
Dmitry.



More information about the wine-devel mailing list