[PATCH] adsldp/tests: Fix misleading indentation warnings

[Fabian Maurer]

> > I know they're intentionally formatted like that. But it causes a lot of
> > compile warning, or errors when using -Werror.
> > I don't think it should be that using todo_wine causes compile warnings.
> > Sure, in a perfect world we'd never need todo_wine, but we're not in a
> > perfect world and I want to avoid compile warnings.
>
> Probably the compiler shouldn't emit this kind of warnings, and disabling
> the warning is another option, perhaps just in a local build if this kind
> of warnings bothers too much.

The warning seems fine to me. The compiler sees a for-loop without braces and
code with the same indentation afterwards. That is usually misleading, it's
just that Wine uses the for-loop in a creative way.

Sure, I could disable the warnings. Doesn't seem like a good solution for me.
Do we want to add -Wno-misleading-indentation to configure? It is (or will be)
needed to compile in maintainer/Werror mode.

> > Alternative would be to manually add curly braces, this would make the
> > compiler happy as well. But fixing the indentation seems more logical to
> > me.
> More logical seems fixing the place a todo_wine was added for.

You can't expect me to fix all those todos just because I don't want warnings.

Regards,
Fabian Maurer