[PATCH] winevulkan: Enable VK_EXT_pipeline_creation_feedback.

Georg Lehmann dadschoorse at gmail.com
Wed Jan 26 11:02:38 CST 2022


On 26.01.22 17:37, Henri Verbeet wrote:
> On Wed, 26 Jan 2022 at 17:35, Georg Lehmann <dadschoorse at gmail.com> wrote:
>>
>> We did previously not support this extension because it runs into 32bit
>> alignment issues. But it is core in 1.3, so we already enabled the
>> functionality. Additionally vkd3d-proton wants to use the extension and it
>> does not care about 32bit.
>>
> Shouldn't that have blocked 1.3 support instead?

Maybe. 32bit winevulkan has a ton of small issues, only exposing a 
non-broken subset is not really possible. E.g. 
VkPhysicalDeviceVulkan11Properties is also broken due to alignment and 
we don't ignore invalid pointers in a lot of situations where we should. 
We would not even be conformant for 1.0 without any extensions.

I think the best policy is to make everything work that is actually 
needed, there aren't a ton of 32bit Vulkan applications. It's mostly 
dxvk and possibly wined3d in the future as far as I understand.

The issue with VK_EXT_pipeline_creation_feedback will result in a 
misreported compile time duration, which is pretty minor in my opinion.



More information about the wine-devel mailing list