[PATCH v3 0/2] MR337: winepulse: Return device-specific values for GetMixFormat and GetDevicePeriod
Huw Davies (@huw)
wine at gitlab.winehq.org
Mon Jul 4 02:52:00 CDT 2022
On Mon Jul 4 07:52:00 2022 +0000, Claire wrote:
> I'm not sure using a `BOOL device` field is really an option, since
> there is currently no existing unix call to get those values, they are
> all computed in the one-shot `pulse_test_connect` then retrieved from a
> global object.
> With regards to splitting this into multiple commits, should I
> force-push to this branch, or make a new Merge Request?
Ah right, in the pulse driver we cache these at the start. I'd suggest making this more like the alsa driver, where we unconditionally call into the unixlib for both `GetMixFormat()` and `GetDevicePeriod()`.
--
https://gitlab.winehq.org/wine/wine/-/merge_requests/337#note_3186
More information about the wine-devel
mailing list