[PATCH v3 0/2] MR337: winepulse: Return device-specific values for GetMixFormat and GetDevicePeriod

Huw Davies (@huw) wine at gitlab.winehq.org
Mon Jul 4 02:59:42 CDT 2022


Huw Davies (@huw) commented about dlls/winepulse.drv/pulse.c:
>      fmt->dwChannelMask = pa_mask;
>  }
>  
> -static void pulse_probe_settings(int render, WAVEFORMATEXTENSIBLE *fmt) {
> +static void pulse_probe_settings(int render, WAVEFORMATEXTENSIBLE *fmt, REFERENCE_TIME *def_period, REFERENCE_TIME *min_period, CHAR *pulse_name) {
If you end up using this in the next version, then please use something like:
```suggestion:-0+0
static void pulse_probe_settings(int render, const char *pulse_name, WAVEFORMATEXTENSIBLE *fmt, REFERENCE_TIME *def_period, REFERENCE_TIME *min_period)
{
```
so that the [out] parameters are at the end and let's put that opening brace on a new line.

-- 
https://gitlab.winehq.org/wine/wine/-/merge_requests/337#note_3187



More information about the wine-devel mailing list