[PATCH vkd3d 04/12] vkd3d-shader/hlsl: Introduce add_load_component() in hlsl.y.
Francisco Casas
fcasas at codeweavers.com
Tue Jul 5 14:30:15 CDT 2022
On 04-07-22 19:02, Zebediah Figura wrote:
> On 7/1/22 16:24, Francisco Casas wrote:
>> Signed-off-by: Francisco Casas <fcasas at codeweavers.com>
>> ---
>> libs/vkd3d-shader/hlsl.y | 100 +++++++++++++++++++++++++++------------
>> 1 file changed, 69 insertions(+), 31 deletions(-)
>>
>> diff --git a/libs/vkd3d-shader/hlsl.y b/libs/vkd3d-shader/hlsl.y
>> index 8fd18868..61c94fa8 100644
>> --- a/libs/vkd3d-shader/hlsl.y
>> +++ b/libs/vkd3d-shader/hlsl.y
>> @@ -272,8 +272,8 @@ static bool implicit_compatible_data_types(struct
>> hlsl_type *t1, struct hlsl_typ
>> return false;
>> }
>> -static struct hlsl_ir_load *add_load(struct hlsl_ctx *ctx, struct
>> list *instrs, struct hlsl_ir_node *var_node,
>> - struct hlsl_ir_node *offset, struct hlsl_type *data_type,
>> const struct vkd3d_shader_location loc);
>> +static struct hlsl_ir_load *add_load_component(struct hlsl_ctx *ctx,
>> struct list *instrs, struct hlsl_ir_node *var_node,
>> + unsigned int comp, const struct vkd3d_shader_location loc);
>
> Can you please use "const struct vkd3d_shader_location *" for any new
> functions?
>
Okay, I will do the same for hlsl_new_load_index(),
hlsl_new_load_component(), and hlsl_new_store_index() in the next
version of the batch then.
More information about the wine-devel
mailing list