Questions about the GitLab patch review process

Rémi Bernon rbernon at codeweavers.com
Fri Jun 10 11:13:22 CDT 2022


On 6/10/22 17:21, Alex Henrie wrote:
> Dear developers,
> 
> I have a couple of questions about how patch reviews on GitLab are
> intended to work:
> 
> * Can I request a review from anyone?
> 
> * Does requesting a review improve the patch's chances of being accepted?
> 
> Thanks for your help.
> 
> -Alex
> 

Imho yes to both, especially to the second question.

For the first question, it's probably best to request review from the 
maintainer of a module. Sometimes there isn't any and looking for 
someone knowledgeable is best.

If there is a maintainer, they will probably be assigned by Alexandre 
anyway at some point (but it saves some effort if you do).

-- 
Rémi Bernon <rbernon at codeweavers.com>



More information about the wine-devel mailing list