[PATCH v3 0/9] MR272: d3dx10: Add D3DX10CreateThreadPump implementation.
Piotr Caban (@piotr)
wine at gitlab.winehq.org
Sun Jun 26 08:32:35 CDT 2022
On Tue Jun 21 08:01:58 2022 +0000, Matteo Bruni wrote:
> Have you thought about merging the two thread functions into one? They
> basically do the exact same thing except for the d3dx functions they
> call and the queue / counter / lock they work on. The generic thread
> function could take a "role" parameter and key the stage-specific
> behavior off of it.
> I haven't actually tried the idea, it might be too confusing and not be
> worth it.
I think it makes the code much harder to read. While the functions are similar there are many minor differences.
More information about the wine-devel