[PATCH 1/3] conhost: Don't compare the console config if the user cancels the dialog

Hugh McMaster hugh.mcmaster at outlook.com
Tue Mar 1 23:08:38 CST 2022


Hi Jacek,

On Wed, 2 Mar 2022 at 03:12, Jacek Caban wrote:
>
> On 3/1/22 12:37, Hugh McMaster wrote:
> > -    PropertySheetW( &header );
> > +    if (!PropertySheetW( &header ))
> > +        return TRUE;
>
>
> It would be even better to use ">0" to handle errors.

While I don't see how a modal dialog could result in an error, I'm
happy to handle the extra case. But don't you mean if (PropertySheetW(
&header ) < 1)? Unless you want to do something like if
(!(PropertySheetW( &header ) > 0))?



More information about the wine-devel mailing list