[PATCH 1/7] winegstreamer: Convert MPEG-1 audio to a major type.

Zebediah Figura (she/her) zfigura at codeweavers.com
Tue May 3 16:18:18 CDT 2022


On 5/3/22 13:27, Anton Baskanov wrote:
> Signed-off-by: Anton Baskanov <baskanov at gmail.com>
> ---
>   dlls/winegstreamer/mfplat.c        |   1 +
>   dlls/winegstreamer/quartz_parser.c | 151 ++++++++++++++++-------------
>   dlls/winegstreamer/unixlib.h       |  11 ++-
>   dlls/winegstreamer/wg_format.c     |  22 ++---
>   dlls/winegstreamer/wg_transform.c  |   2 +
>   dlls/winegstreamer/wm_reader.c     |   4 +
>   6 files changed, 106 insertions(+), 85 deletions(-)

I'm not necessarily opposed, but it also doesn't seem clear that this is 
an improvement. The audio fields used for MPEG-1 audio is a proper 
subset of those used for raw audio, and one can see from the diffstat 
that the code doesn't exactly get simpler this way.

Is this patch necessary or helpful for others later in the series?



More information about the wine-devel mailing list