[PATCH 1/7] winegstreamer: Convert MPEG-1 audio to a major type.

[Anton Baskanov]

On 04.05.2022 04:18, Zebediah Figura (she/her) wrote:
> On 5/3/22 13:27, Anton Baskanov wrote:
>> Signed-off-by: Anton Baskanov <baskanov at gmail.com>
>> ---
>>    dlls/winegstreamer/mfplat.c        |   1 +
>>    dlls/winegstreamer/quartz_parser.c | 151 ++++++++++++++++-------------
>>    dlls/winegstreamer/unixlib.h       |  11 ++-
>>    dlls/winegstreamer/wg_format.c     |  22 ++---
>>    dlls/winegstreamer/wg_transform.c  |   2 +
>>    dlls/winegstreamer/wm_reader.c     |   4 +
>>    6 files changed, 106 insertions(+), 85 deletions(-)
> 
> I'm not necessarily opposed, but it also doesn't seem clear that this is
> an improvement. The audio fields used for MPEG-1 audio is a proper
> subset of those used for raw audio, and one can see from the diffstat
> that the code doesn't exactly get simpler this way.
> 
> Is this patch necessary or helpful for others later in the series?
> 

It was supposed to make the next patch a bit less awkward, but you are 
right, given all the extra changes, it's probably not worth it.

Removed it in v2.