[PATCH vkd3d v2 10/10] vkd3d-shader/hlsl: Lower numeric casts.

[Zebediah Figura]

On 5/10/22 08:08, Giovanni Mascellani wrote:
> Signed-off-by: Giovanni Mascellani <gmascellani at codeweavers.com>
> Signed-off-by: Francisco Casas <fcasas at codeweavers.com>
> ---
> Functionality-wise, this should be able to wholly replace lower_broadcasts().
> However, it generates less vectorized code, so I don't know what is the
> general sentiment WRT immediately remove lower_broadcasts(), remove it
> once more vectorized code is generated (or an effective vectorization pass
> cares about it), or whatever else.
> ---
>   libs/vkd3d-shader/hlsl.h                      |  4 +
>   libs/vkd3d-shader/hlsl.y                      | 52 +++++-----
>   libs/vkd3d-shader/hlsl_codegen.c              | 97 +++++++++++++++++++
>   tests/hlsl-duplicate-modifiers.shader_test    |  2 +-
>   tests/hlsl-initializer-matrix.shader_test     |  2 +-
>   ...lsl-return-implicit-conversion.shader_test | 10 +-
>   tests/hlsl-shape.shader_test                  | 10 +-
>   tests/matrix-semantics.shader_test            | 14 +--
>   8 files changed, 146 insertions(+), 45 deletions(-)
> 

I don't think this feels like the right place. Can we handle this when 
parsing explicit casts instead?