[PATCH vkd3d v2 10/10] vkd3d-shader/hlsl: Lower numeric casts.

Giovanni Mascellani gmascellani at codeweavers.com
Mon May 16 09:58:23 CDT 2022


Hi,

Il 13/05/22 01:18, Zebediah Figura ha scritto:
> I don't think this feels like the right place. Can we handle this when 
> parsing explicit casts instead?

Hm, this is useful in many places beside explicit casts. Actually, most 
tests fixed by this commit are not explicit casts. In principle we could 
do the same processing each time we add any cast, explicit or not, but 
that means we have to hook in many places, making everything more 
brittle. What's the problem with having this as an optimization pass? 
Why is that different from lower_broadcasts()?

Thanks, Giovanni.



More information about the wine-devel mailing list