EDIT_WM_Create fix.

Rein Klazes rklazes at xs4all.nl
Sun Oct 19 10:10:13 CDT 2003


Sent to wine-devel as well: this might break some odd edit controls that
I did not catch.

This fixes masked edit controls used by applications created by Power
Builder, it fixes bug #807.
Power builder depends on the return value of the WM_CREATE message by
the EditWndProc to be != 0. 

Now I spent some time creating EDIT windows, varying parameters (with or
without text), varying styles including multilines even tested the edit
part of a combobox. In all cases the WM_CREATE message return value
turned out to be 1.  So at the very least this seems to be the common
case, and not zero as in wine's implementation. So I propose to put that
in, and if it breaks hope it will be caught. 

	controls	: edit.c
	A WM_CREATE message sent to an Edit window procedure should
	return 1. Power Builder masked edit controls depend on it.

Rein Klazes
rklazes at xs4all.nl
-------------- next part --------------
--- wine/controls/edit.c	2003-09-17 08:21:31.000000000 +0200
+++ mywine/controls/edit.c	2003-10-19 16:38:24.000000000 +0200
@@ -3780,7 +3780,11 @@
        /* force scroll info update */
-       return 0;
+       /* The rule seems to return 1 here for success */
+       /* Power Builder masked edit controls will crash  */
+       /* if not. */
+       /* FIXME: is that in all cases so ? */
+       return 1;

More information about the wine-patches mailing list