shell32/tests: Fix some expected FindExecutable() error codes.

Francois Gouget fgouget at codeweavers.com
Mon Apr 2 12:24:40 CDT 2007


Add comments indicating which Windows version returns a given error code.
---
I tested on Win98, NT4, WinXP and Win2003 and could not find a platform 
that returns SE_ERR_FNF for the middle test. So I must have gotten it 
wrong the first time around.

 dlls/shell32/tests/shlexec.c |    6 +++---
 1 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/dlls/shell32/tests/shlexec.c b/dlls/shell32/tests/shlexec.c
index 580cdfd..37d96ee 100644
--- a/dlls/shell32/tests/shlexec.c
+++ b/dlls/shell32/tests/shlexec.c
@@ -697,12 +697,12 @@ static void test_find_executable(void)
 
     strcpy(command, "your word");
     rc=(int)FindExecutableA(NULL, NULL, command);
-    ok(rc == SE_ERR_FNF || rc > 32, "FindExecutable(NULL) returned %d\n", rc);
+    ok(rc == SE_ERR_FNF || rc > 32 /* nt4 */, "FindExecutable(NULL) returned %d\n", rc);
     ok(strcmp(command, "your word") != 0, "FindExecutable(NULL) returned command=[%s]\n", command);
 
     strcpy(command, "your word");
     rc=(int)FindExecutableA(tmpdir, NULL, command);
-    todo_wine ok(rc == SE_ERR_FNF || rc > 32, "FindExecutable(NULL) returned %d\n", rc);
+    ok(rc == SE_ERR_NOASSOC /* >= win2000 */ || rc > 32 /* win98, nt4 */, "FindExecutable(NULL) returned %d\n", rc);
     ok(strcmp(command, "your word") != 0, "FindExecutable(NULL) returned command=[%s]\n", command);
 
     sprintf(filename, "%s\\test file.sfe", tmpdir);
@@ -723,7 +723,7 @@ static void test_find_executable(void)
 
     sprintf(filename, "%s\\test file.shl", tmpdir);
     rc=(int)FindExecutableA(filename, NULL, command);
-    ok(rc > 32, "FindExecutable(%s) returned %d\n", filename, rc);
+    ok(rc == SE_ERR_FNF /* NT4 */ || rc > 32, "FindExecutable(%s) returned %d\n", filename, rc);
 
     sprintf(filename, "%s\\test file.shlfoo", tmpdir);
     rc=(int)FindExecutableA(filename, NULL, command);
-- 
1.4.4.4




More information about the wine-patches mailing list