msi: correctly handle return value of msi_realloc. [try 2]
Lionel_Debroux
lionel_debroux at yahoo.fr
Sun Dec 30 14:25:09 CST 2007
Several functions in dlls/msi/action.c and dlls/msi/database.c use
constructs of the form
ptr = msi_realloc (ptr, newsize);
In the (admittedly very unlikely) situation where msi_realloc fails,
this leaks, or even faults:
filename = msi_realloc(filename, len * sizeof(WCHAR) + sizeof(szlnk));
memcpy(filename + len, szlnk, sizeof(szlnk));
This new version of the patch strips two chunks that James Hawkins
commented on, I'll handle them later.
2007-12-30 Lionel Debroux <lionel_debroux at yahoo.fr>
* dlls/msi/action.c, dlls/msi/database.c:
msi: correctly handle return value of msi_realloc.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0002-msi-correctly-handle-return-value-of-msi_realloc.patch
Type: text/x-diff
Size: 3105 bytes
Desc: not available
Url : http://www.winehq.org/pipermail/wine-patches/attachments/20071230/2266f442/attachment-0001.patch
More information about the wine-patches
mailing list