Spore patch to fix UI and Part descriptions

H. Verbeet hverbeet at gmail.com
Fri Aug 22 03:14:08 CDT 2008

2008/8/22 Andrew Fenn <andrewfenn at gmail.com>:
> -        *ppZStencilSurface = NULL;
> +        /* *ppZStencilSurface = NULL; */
> +        return D3DERR_NOTFOUND;
>      }
>      LeaveCriticalSection(&d3d9_cs);
This should be in a separate patch with its own test, it's unrelated
to the scissor test. If ppZStencilSurface should be left alone, you
should simply remove the line, not comment it. If it should be set to
NULL, you should leave the line alone. You're also still holding the
critical section here, as Marcus already mentioned.

For some examples of things to test for scissor rectangles, see
test_lockrect_invalid() in dlls/d3d9/tests/surface.c and
dlls/ddraw/tests/dsurface.c. Also, please don't add trailing

More information about the wine-patches mailing list