LookupAccountSidW() handles first user account

Paul Bryan Roberts pbronline-wine at yahoo.co.uk
Fri Sep 26 05:55:31 CDT 2008

LookupAccountNameW() has a stubbed but non-empty, incomplete, buggy 
implementation.  It fails a number of unit tests but Wine code relies on 

This is the SEVENTH of a series of NINE patches that provide what may be 
a reasonable first pass implementation of LookupAccountNameA() and 
LookupAccountNameW() that:

    - works for well known SIDs
    - works for 'first user account'
    - adds handling of 'first user account' to LookupAccountSid
    - passes existing units tests for LookupAccountName
    - corrects knock-on regression failures in the advapit32/security.c 
unit tests (there may be others elsewhere)
    - allows progress towards the resolution of Bug 14334

The units tests for LookupAccountName use LookupAccountSid so if the 
former is to support the 'first user account' SID then so must the 
latter and the latter needs prior implementation.

Wot, no unit test ?

No -  there already is one.  It just doesn't as a failure.  Here's the 
before and after output from my Wine test VM followed by the 
'equivalent' from my native Windows test VM:

< security.c:1109:  S-1-5-21-1548840911-2268645679-1347247377-1000 
couldn't be mapped
 > security.c:1107:  S-1-5-21-1548840911-2268645679-1347247377-1000 
holly\ubuntu 1

< security.c:1107:  S-1-5-21-1715567821-287218729-725345543-1000 
W2KSP4\pbr 1
 > security.c:1107:  S-1-5-21-1715567821-287218729-725345543-1000 
W2KSP4\pbr 1

Why remove the trace from LookupAccountSidA() ?  'cos I was admonished 
for not removing 'superflous' trace in an earlier submission.

-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: 0010-LookupAccountSidW-handle-first-user-account.txt
Url: http://www.winehq.org/pipermail/wine-patches/attachments/20080926/3c39c139/attachment.txt 

More information about the wine-patches mailing list