msvfw32: Force lower-case 'vidc/vids/audc' etc. when opening new driver.

Joerg-Cyril.Hoehle at t-systems.com Joerg-Cyril.Hoehle at t-systems.com
Mon May 23 07:14:57 CDT 2011


Hi,

in 2009, my tests proved ICOpen's case insensitivity and I submitted
case-insensitivity patches to Wine's built-in codecs.  This fixed bug #15915.

This was fine for Wine, however other codecs do not contain such a case
insensitive check when comparing against 'vidc' aka. ICTYPE_VIDEO.
E.g. I had a look at www.xvid.org source after I read about bug #13194.
Therefore another mechanism is needed -- within winmm, not in the codecs.

My notes about win.ini and registry contents show that apps use
varying case.  Sometimes, what an installer puts into win.ini and the
registry doesn't even match (VIDC.IV50 vs. vidc.iv50).  Here's a patch
to generally preserve the initial case from installed handlers, but
downcase the others.  Downcase because 'vidc',
'vids' and 'audc' are all lower-case.  The other half of the fcc,
e.g. 'XVID' or 'iv50', is left untouched.

This should fix bug #13194 but nobody responded.

This fixes #15915 again, centrally.  My 2009 codec patches are now
obsolete but I've not reverted them because they don't harm.

mmioStringToFOURCC knows MMIO_TOUPPER but what we really need is LOWERCASE.

Regards,
	Jörg Höhle
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-msvfw32-Force-lower-case-vidc-vids-audc-etc.-when-op.patch
Type: application/octet-stream
Size: 1772 bytes
Desc: 0001-msvfw32-Force-lower-case-vidc-vids-audc-etc.-when-op.patch
URL: <http://www.winehq.org/pipermail/wine-patches/attachments/20110523/05afe32e/attachment.obj>


More information about the wine-patches mailing list