[PATCH 1/1] ddraw: Always pin surfaces.

Henri Verbeet hverbeet at codeweavers.com
Wed Feb 22 02:36:28 CST 2012

DirectDraw applications are just hopeless. Note that this effectively disables
PBOs for all ddraw surfaces except the real frontbuffer, which could introduce
a minor performance hit. In practice PBOs don't actually seem to buy us a lot
though, and even less so since we introduced the ddraw shadow frontbuffer.
Nevertheless, it's a bit unfortunate to introduce this kind of change this far
into the freeze.

This is for bug 26918.
 dlls/ddraw/surface.c |    3 +--
 1 files changed, 1 insertions(+), 2 deletions(-)

diff --git a/dlls/ddraw/surface.c b/dlls/ddraw/surface.c
index 2e97510..10643f5 100644
--- a/dlls/ddraw/surface.c
+++ b/dlls/ddraw/surface.c
@@ -5526,8 +5526,7 @@ HRESULT ddraw_surface_init(IDirectDrawSurfaceImpl *surface, IDirectDrawImpl *ddr
      * the surface isn't mapped, and that updates done this way will be
      * visible on the screen. The game Nox is such an application,
      * Commandos: Behind Enemy Lines is another. */
-    if (version == 1)
-        flags |= WINED3D_SURFACE_PIN_SYSMEM;
     if (desc->ddsCaps.dwCaps & DDSCAPS_PRIMARYSURFACE)

More information about the wine-patches mailing list