[PATCH] msi: fixed missing free in an error path (Coverity)

Marcus Meissner marcus at jet.franken.de
Sat Mar 8 02:48:58 CST 2014


1191503 Resource leak
---
 dlls/msi/action.c | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/dlls/msi/action.c b/dlls/msi/action.c
index 0cc40a8..c87fff5 100644
--- a/dlls/msi/action.c
+++ b/dlls/msi/action.c
@@ -5821,7 +5821,10 @@ static UINT ITERATE_InstallService(MSIRECORD *rec, LPVOID param)
         ERR("Query failed\n");
         goto done;
     }
-    if (!(key = MSI_RecordGetString(row, 6))) goto done;
+    if (!(key = MSI_RecordGetString(row, 6))) {
+        msiobj_release(&row->hdr);
+        goto done;
+    }
     file = msi_get_loaded_file(package, key);
     msiobj_release(&row->hdr);
     if (!file)
-- 
1.8.4.5




More information about the wine-patches mailing list