comctl32/tests: Remove dead assignments in treeview.c (Cppcheck)
Bruno Jesus
00cpxxx at gmail.com
Fri Oct 31 20:44:07 CDT 2014
[dlls\comctl32\tests\treeview.c:666] ->
[dlls\comctl32\tests\treeview.c:675]: (performance) Variable 'crColor'
is reassigned a value before the old one has been used.
[dlls\comctl32\tests\treeview.c:723] ->
[dlls\comctl32\tests\treeview.c:734]: (performance) Variable
'ulMinIndent' is reassigned a value before the old one has been used.
[dlls\comctl32\tests\treeview.c:724] ->
[dlls\comctl32\tests\treeview.c:737]: (performance) Variable
'ulMoreThanTwiceMin' is reassigned a value before the old one has been
used.
[dlls\comctl32\tests\treeview.c:722] ->
[dlls\comctl32\tests\treeview.c:739]: (performance) Variable
'ulIndent' is reassigned a value before the old one has been used.
[dlls\comctl32\tests\treeview.c:917] ->
[dlls\comctl32\tests\treeview.c:925]: (performance) Variable 'crColor'
is reassigned a value before the old one has been used.
[dlls\comctl32\tests\treeview.c:977] ->
[dlls\comctl32\tests\treeview.c:985]: (performance) Variable
'bPreviousSetting' is reassigned a value before the old one has been
used.
[dlls\comctl32\tests\treeview.c:978] ->
[dlls\comctl32\tests\treeview.c:992]: (performance) Variable
'bNewSetting' is reassigned a value before the old one has been used.
-------------- next part --------------
diff --git a/dlls/comctl32/tests/treeview.c b/dlls/comctl32/tests/treeview.c
index ce65f06..eb7d7e5 100644
--- a/dlls/comctl32/tests/treeview.c
+++ b/dlls/comctl32/tests/treeview.c
@@ -663,7 +663,7 @@ static void test_focus(void)
static void test_get_set_bkcolor(void)
{
- COLORREF crColor = RGB(0,0,0);
+ COLORREF crColor;
HWND hTree;
hTree = create_treeview_control(0);
@@ -719,9 +719,9 @@ static void test_get_set_imagelist(void)
static void test_get_set_indent(void)
{
- int ulIndent = -1;
- int ulMinIndent = -1;
- int ulMoreThanTwiceMin = -1;
+ int ulIndent;
+ int ulMinIndent;
+ int ulMoreThanTwiceMin;
HWND hTree;
hTree = create_treeview_control(0);
@@ -914,7 +914,7 @@ static void test_get_set_scrolltime(void)
static void test_get_set_textcolor(void)
{
/* If the value is -1, the control is using the system color for the text color. */
- COLORREF crColor = RGB(0,0,0);
+ COLORREF crColor;
HWND hTree;
hTree = create_treeview_control(0);
@@ -974,8 +974,8 @@ static void test_get_set_tooltips(void)
static void test_get_set_unicodeformat(void)
{
- BOOL bPreviousSetting = FALSE;
- BOOL bNewSetting = FALSE;
+ BOOL bPreviousSetting;
+ BOOL bNewSetting;
HWND hTree;
hTree = create_treeview_control(0);
More information about the wine-patches
mailing list