[PATCH] mshtml: Make it clear that ATTR_FIX_PX and ATTR_FIX_URL as exclusive (Coverity)
Nikolay Sivov
nsivov at codeweavers.com
Tue Nov 10 13:31:29 CST 2015
Signed-off-by: Nikolay Sivov <nsivov at codeweavers.com>
---
Otherwise first allocated val is leaked. Jacek, can you confirm?
dlls/mshtml/htmlstyle.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/dlls/mshtml/htmlstyle.c b/dlls/mshtml/htmlstyle.c
index 33318ff..d0953f2 100644
--- a/dlls/mshtml/htmlstyle.c
+++ b/dlls/mshtml/htmlstyle.c
@@ -405,7 +405,7 @@ HRESULT set_nsstyle_attr(nsIDOMCSSStyleDeclaration *nsstyle, styleid_t sid, cons
if(value) {
if(flags & ATTR_FIX_PX)
val = fix_px_value(value);
- if(flags & ATTR_FIX_URL)
+ else if(flags & ATTR_FIX_URL)
val = fix_url_value(value);
}
--
2.6.2
More information about the wine-patches
mailing list