[PATCH 2/2] mscoree: Implement ICorRuntimeHost::CreateDomain{, Ex}(). (try 5)

Vincent Povirk vincent at codeweavers.com
Wed Feb 17 13:38:10 CST 2016


Signed-off-by: Vincent Povirk <vincent at codeweavers.com>

I guess the domain actually was being set by mono_thread_attach. We
only originally used that to make sure mono set up the thread before
we made calls on it, and there wasn't much thought put into which
domain we set. We should check the previous thread domain and restore
it as necessary. But this was an issue before your patch, so I don't
think it's critical to address it first.

I'm not sure about the __LP64__ define. Maybe we should check for x86
(since this won't work on ARM either)? Also, it may be cleaner to use
an if statement around the call to the test function, rather than
conditional compilation.

We may even want to run the test on all platforms, and stop early
(with a failing test) if the runtime fails to load. Then we can make
the failure a todo on non-x86.



More information about the wine-patches mailing list