[PATCH] ole32: Fix CreataDataCache() return value when requested riid is not IUnknown, for aggregation case
huw at codeweavers.com
Tue Mar 22 04:21:00 CDT 2016
On Mon, Mar 21, 2016 at 11:55:57AM +0300, Nikolay Sivov wrote:
> Signed-off-by: Nikolay Sivov <nsivov at codeweavers.com>
> dlls/ole32/datacache.c | 2 +-
> dlls/ole32/tests/ole2.c | 1 -
> 2 files changed, 1 insertion(+), 2 deletions(-)
> diff --git a/dlls/ole32/datacache.c b/dlls/ole32/datacache.c
> index e93e867..21f63d3 100644
> --- a/dlls/ole32/datacache.c
> +++ b/dlls/ole32/datacache.c
> @@ -2464,7 +2464,7 @@ HRESULT WINAPI CreateDataCache(
> * IUnknown pointer can be returned to the outside.
> if ( pUnkOuter && !IsEqualIID(&IID_IUnknown, riid) )
> - return CLASS_E_NOAGGREGATION;
> + return E_INVALIDARG;
I'm not a huge fan of changing error codes for the sake
of it, especially as:
a. This is moving to a more generic code.
b. In practice this won't be seen except during app development.
However, since we already have a test for it...
Signed-off-by: Huw Davies <huw at codeweavers.com>
More information about the wine-patches