February 2023 - wine-gitlab

[PATCH v2 0/4] MR2000: ws2_32/tests: Try to disable firewall before testing with any addr.

by Jinoh Kang (＠iamahuman)

test_reuseaddr and test_exclusiveaddruse bind to the wildcard address (0.0.0.0 or [::]). This may trigger a firewall alert on Windows 7, and the alert UI window may interfere with user32:msg tests. Fix this by trying to disable the firewall, and skipping the wildcard address tests if it fails. Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=53891 Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=54202 -- v2: ws2_32/tests: Try to disable firewall before testing with any addr. ws2_32/tests: Factor out test_exclusiveaddruse from test_reuseaddr. ws2_32/tests: Do ANY address tests in a separate loop in test_reuseaddr. webservices/tests: Move firewall code to a common header. https://gitlab.winehq.org/wine/wine/-/merge_requests/2000

1 month, 1 week

5
8
0 0

[PATCH 0/1] MR1269: wined3d: Disable CSMT when running on a single core.

by Anton Baskanov (＠baskanov)

- Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=45893 - Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=47767 - Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=44546 -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1269

1 month, 2 weeks

6
11
0 0

[PATCH 0/1] MR1228: wined3d: support direct3d shader model 1,2,3

by Fan WenJie (＠fanwenjie)

vkd3d_shader_compile_info::source_type can not hard write to VKD3D_SHADER_SOURCE_DXBC_TPF, it is decided by magic number of shader source. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1228

1 month, 2 weeks

4
5
0 0

[PATCH 0/1] MR1981: shell32: Handle NULL sPathTarget in all places before copying it.

by Gabriel Ivăncescu (＠insn)

This can crash if you parse, for example, "/" with the desktop IShellFolder. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1981

1 month, 2 weeks

2
3
0 0

[PATCH 0/1] MR667: win32u: Ignore SetWindowPos() if it is trying to change topmost state for child window.

by Paul Gofman (＠gofman)

I think the behaviour of SetWindowPos() in this case is partially explained by the fact that topmost state is not strictly applicable to child windows and so Windows denies such requests. Child window can still end up with WS_EX_TOPMOST style if it was set at window creation (doesn't work this way in Wine now) or, e. g., like in the test added in the patch. Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=20190 Also fixes game load dialog in Indiana Jones and the Infernal Machine. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/667

1 month, 4 weeks

6
6
0 0

[PATCH 0/1] MR1425: ntdll: Return FILE_DEVICE_DISK for Unix FIFOs and sockets from get_device_info().

by Paul Gofman (＠gofman)

Currently GetFileType() ends up returning the file type solely based on Unix fd type if it gets it from server. The problematic case is when our process gets a pipe or socket fd as a stdin or stderr from Unix. The server object which gets created through wine_server_fd_to_handle is a regular file regardless of the underlying Unix fd type. It probably can't be anything else, at least for pipes, as the pipe should have both ends but we have only one in this case. That causes problems, e. g., with libuv (used, e. g., by Vampire Survivors). It checks stdout handle type and if it is pipe it tries to do SetNamedPipeHandleState() on it and does not tolerate the failure. It looks more sensible to me to report all the pipes and sockets created through wine_server_fd_to_handle() as regular files as that matches the server objects we have for them. When that is not the case we should get the correct type from server fd type. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1425

2 months, 2 weeks

4
4
0 0

[PATCH 0/1] MR1185: Update .metrics-dashboard.yml, Dockerfile

by waynus (＠waynus)

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/1185

4 months, 3 weeks

3
2
0 0

[PATCH 0/1] MR411: win32u: Don't load bitmap only TTF fonts without bitmap table.

by Paul Gofman (＠gofman)

The offending font is NotoColorEmoji.ttf which is present in, e. g., google-noto-emoji-color-fonts or noto-fonts-emoji packages available in various distribution. Attempting to load this font on Windows 10 (with AddFontResourceA() or open it with default font viewer) fails while currently succeeds on Windows. fontforge also refuses to open this font. That is because the font is bitmap only but missing bitmap table. Some apps (Glyph launcher is an example) try to GetOutlineTextMetrics() on this font and do not expect that to have an error return (as we currenly do), which leads to crash on unhandled division by zero exception. I am attaching a bitmap-only ttf test font (with only one bitmap) which I created with fontforge to make sure that such font can still be loaded in Wine. This font also loads on Windows (both with AddFontResourceA() and with default font viewer). There are other font types which can be legitimately missing EBDT table, but FT_Load_Sfnt_Table() returns a different error for those and my patch doesn't reject those fonts. [test.ttf](/uploads/b41472180b80c2c53f9dcc06055990f0/test.ttf) -- https://gitlab.winehq.org/wine/wine/-/merge_requests/411

4 months, 4 weeks

5
12
0 0

[PATCH v3 0/3] MR1152: ntdll: Fixes for Overwatch 2.

by Torge Matthies (＠tmatthies)

Overwatch 2 doesn't like the win32u `-syscall` conversion that happened a while back, because it hooks KiUserCallbackDispatcher. This MR fixes it up to match what Overwatch 2 expects. -- v3: ntdll: Pass KiUserCallbackDispatcher parameters on stack. ntdll: Add 5-byte nop to start of KiUserCallbackDispatcher. ntdll: Align stack pointer when calling KiUserCallbackDispatcher. https://gitlab.winehq.org/wine/wine/-/merge_requests/1152

5 months

4
8
0 0

[PATCH v12 0/10] MR391: scrrun: Implement MoveFolder().

by Robert Wilhelm (＠sloper42)

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=52128 Signed-off-by: Robert Wilhelm <robert.wilhelm(a)gmx.net> -- v12: scrrun: Return path not found error if no folders were moved in MoveFolder(). scrrun: return path not found error if source ends with path separator in MoveFolder(). scrrun: Move directories only in MoveFolder(). scrrun: Support wildcards in MoveFolder(). scrrun: Move source dir into destination dir if destination ends with separator in MoveFolder(). scrrun: Check that source is directory in MoveFolder(). scrrun: Check for non-existant source in MoveFolder(). scrrun: Test MoveFolder with already existing destination. scrrun: Check for null and empty arguments in MoveFolder. scrrun: Implement MoveFolder(). https://gitlab.winehq.org/wine/wine/-/merge_requests/391

5 months, 1 week

3
14
0 0

2024

2023

2022

wine-gitlab February 2023