March 2024 - wine-gitlab

[PATCH v5 0/10] MR739: vkd3d-shader/hlsl: Parse state blocks, part 1.

by Francisco Casas (＠fcasas)

I am still working on parsing the remaining features of the effects framework, such as the FX functions for the state block entries -- such as SetBlendState() -- and the "compile" and "Compileshader()" syntax. However, after adding the many tests included in 2/7 and reading the feedback from !708, I think that this first batch of patches are going in the right direction in terms of parsing the state blocks and how to represent them internally. As Nikolay mentioned in https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/708#note_64421 and https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/708#note_64444 there are many types of state blocks entries, which should be identified for writing the effect metadata. A part that may cause discussion on this series is that I kept the representation of `struct hlsl_state_block_entry` using a `hlsl_block` to keep it general enough to represent all these types of state block entries, thinking on later implementing a helper to identify which type of entry we are dealing with. Even though, as Nikolay pointed out, the instruction set of fx shaders is different, I still think that HLSL IR should be enough to represent the rhs of state blocks, and hopefully we won't need to pollute it too much (apart from the introduction of hlsl_ir_undeclared_load in 4/7 to avoid creating a new variable) if we find operations that are fx-specific, since I intend to represent calls to FX functions with the same `struct hlsl_state_block_entry`, given that they cannot be called in regular HLSL code. There are many validations that are applied on regular HLSL that still should be applied to state blocks, such as the use of valid swizzles and the correct use of operators. -- v5: vkd3d-shader/hlsl: Allow KW_PIXELSHADER and KW_VERTEXSHADER as stateblock lhs. vkd3d-shader/hlsl: Store state block on pass variables. vkd3d-shader/hlsl: Parse list of state blocks. vkd3d-shader/hlsl: Introduce hlsl_ir_stateblock_constant. vkd3d-shader/hlsl: Parse and store state blocks on variables. tests: Add tests for "compile" and CompileShader() syntax. tests: Add tests for fxgroup syntax. tests: Test function call syntax for state blocks. tests: Add more state block syntax tests. vkd3d-shader/hlsl: Also call dce before lowering deref paths. https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/739

3 weeks, 1 day

5
14
0 0

[PATCH v5 0/1] MR333: vkd3d-shader/hlsl: Add refract() function.

by Nikolay Sivov (＠nsivov)

Signed-off-by: Nikolay Sivov <nsivov(a)codeweavers.com> -- v5: vkd3d-shader/hlsl: Add refract() function. https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/333

3 weeks, 2 days

2
2
0 0

[PATCH v20 0/5] MR564: vkd3d-shader/ir: Transform clip/cull signature elements into an array.

by Conor McCarthy (＠cmccarthy)

-- v20: tests/d3d12: Test multiple clip distance inputs in test_clip_distance(). tests/d3d12: Use five clip distances for the multiple test in test_clip_distance(). vkd3d-shader/ir: Transform clip/cull outputs and patch constants into arrays. vkd3d-shader/ir: Transform clip/cull inputs into an array. vkd3d-shader/spirv: Support no-op signature elements. https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/564

3 weeks, 5 days

3
8
0 0

[PATCH 0/1] MR746: vkd3d-shader/hlsl: Allow 'export' modifier on functions.

by Nikolay Sivov (＠nsivov)

Signed-off-by: Nikolay Sivov <nsivov(a)codeweavers.com> -- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/746

4 weeks

4
3
0 0

[PATCH v2 0/7] MR744: vkd3d-shader/hlsl: Improve SM1 support for non-float operations, part 5.

by Francisco Casas (＠fcasas)

-- v2: vkd3d-shader/hlsl: Use LOGIC_AND instead of MUL in all(). vkd3d-shader/hlsl: Use LOGIC_OR instead of BIT_OR in any(). vkd3d-shader/ir: Add missing src swizzle in vsir_program_lower_texkills(). tests: Add failing test for clip.shader_test in SM1. https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/744

4 weeks, 1 day

3
15
0 0

[PATCH v2 0/2] MR747: vkd3d: Add some missing includes.

by Giovanni Mascellani (＠giomasce)

-- v2: tests: Include vkd3d_d3d12.h in utils.h. include: Include stddef.h in vkd3d_shader.h. https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/747

4 weeks, 1 day

3
4
0 0

[PATCH v3 0/4] MR745: hlsl: Avoid HLSL_CLASS_OBJECT, part 1.

by Zebediah Figura (＠zfigura)

HLSL_CLASS_OBJECT does not really have much in common, and a lot of code currently uses it assuming that all objects are resources, which is not actually true. Most users of HLSL_CLASS_OBJECT want to check for specific types, and so we can simplify code a fair amount by promoting all object "base types" to top-level classes. This series is a first step, comprising some cleanup towards that goal. -- v3: vkd3d-shader/hlsl: Use hlsl_is_numeric_type() in type_has_object_components(). vkd3d-shader/hlsl: Simplify type_has_object_components(). https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/745

4 weeks, 1 day

4
8
0 0

[PATCH 0/2] MR743: ci: Run tests on llvmpipe from Mesa 24.0.3.

by Giovanni Mascellani (＠giomasce)

The Mesa version in Debian bookworm (22.3.6) we use for testing is now a bit outdated. While it's valuable to test on older drivers because they might be more representative of what users are running, it's also useful to test on recent drivers, which gives a less noisy signal to developers. For the moment we enable it only for llvmpipe, because RADV is already passing all the tests anyway. And we don't bother with 32 bit here. On llvmpipe using Mesa 24 fixes three shader runner tests. -- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/743

4 weeks, 1 day

3
5
0 0

[PATCH v2 0/2] MR742: vkd3d-shader/fx: Add an option to include empty buffers in the effect binary.

by Nikolay Sivov (＠nsivov)

Signed-off-by: Nikolay Sivov <nsivov(a)codeweavers.com> -- v2: vkd3d-shader/fx: Add an option to include empty buffers in the effect binary. https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/742

4 weeks, 1 day

5
6
0 0

[PATCH v3 0/4] MR741: Cachestub

by Stefan Dösinger (＠stefan)

None -- v3: tests: Add tests for creating D3D12ShaderCacheSession objects. https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/741

4 weeks, 1 day

3
7
0 0

2024

2023

2022

wine-gitlab March 2024