- wine-gitlab - winehq.org

[PATCH v2 0/2] MR5652: Draft: user32: Skip SendInput keyboard tests if a layout change is detected.

by Alexandros Frantzis (＠afrantzis)

In some Win10 testbot images (notably jp and cn), we can get a spurious layout change after creating the test window. Detect this and skip the tests since the test expectations (e.g., wchar mappings) are now invalid. -- v2: user32: Remove workaround for SendInput keyboard tests on zh_CN. user32: Skip affected keyboard tests if a spurious layout change is detected. https://gitlab.winehq.org/wine/wine/-/merge_requests/5652

2 days, 20 hours

3
3
0 0

[PATCH v2 0/2] MR5634: win32u: Ignore WM_MOUSEMOVE when tracking scrollbar and arrow/track is clicked

by Fabian Maurer (＠DarkShadow44)

This fixes a regression from bb496ea8. Also closer mimics windows behavior, moving the mouse should not reset the scrolling timer. Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=56582 -- v2: win32u: Only set scroll timer if it's not running win32u: Refactor out scroll timer handling https://gitlab.winehq.org/wine/wine/-/merge_requests/5634

2 days, 21 hours

2
2
0 0

[PATCH v3 0/2] MR5652: Draft: user32: Skip SendInput keyboard tests if a layout change is detected.

by Alexandros Frantzis (＠afrantzis)

In some Win10 testbot images (notably jp and cn), we can get a spurious layout change after creating the test window. Detect this and skip the tests since the test expectations (e.g., wchar mappings) are now invalid. -- v3: user32/tests: Remove workaround for SendInput keyboard tests on zh_CN. user32/tests: Skip affected keyboard tests if a spurious layout change is detected. https://gitlab.winehq.org/wine/wine/-/merge_requests/5652

2 days, 23 hours

3
3
0 0

[PATCH 0/1] MR5659: d3d9/tests: Remove leftover debugging code.

by Elizabeth Figura (＠zfigura)

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/5659

2 days, 23 hours

2
1
0 0

[PATCH 0/1] MR5658: winevulkan: Make device memory wrapper available in callbacks.

by Arek Hiler (＠ivyl)

With [`VK_EXT_device_address_binding_report`](https://registry.khronos.org/vulkan/specs/1.3-extensions/man/html/VK_EXT_device_address_binding_report.html) we can get [debug_util](https://registry.khronos.org/vulkan/specs/1.3-extensions/man/ht… callbacks used to track memory bindings. Since it's the host's implementation that starts the callback we have to be sure that we have a way of converting it to the client side's variant before it's added to the handle map - i.e. we don't know the host handle at that time yet. This is [used by vkd3d-proton](https://github.com/HansKristian-Work/vkd3d-proton/pull/1962). Requires Mesa with https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/28649. before (note the missing BIND for VkDevice which actually means `VkDeviceMemory`): ``` vkd3d-proton % VKD3D_TEST_FILTER=create_placed_resource_size VKD3D_CONFIG=fault VKD3D_DEBUG=trace ~/src/wine/build/wine ./tests/d3d12.exe 2>&1 | grep vkd3d_address_binding_callback trace:vkd3d-proton:vkd3d_address_binding_callback: BIND || VkBuffer || VA ffff800100200000 || size 0000000001000000. trace:vkd3d-proton:vkd3d_address_binding_callback: BIND || VkImage || VA ffff800100200000 || size 000000000019a000. trace:vkd3d-proton:vkd3d_address_binding_callback: UNBIND || VkImage || VA ffff800100200000 || size 000000000019a000. trace:vkd3d-proton:vkd3d_address_binding_callback: UNBIND || VkBuffer || VA ffff800100200000 || size 0000000001000000. :trace:vkd3d-proton:vkd3d_address_binding_callback: UNBIND || VkDevice || VA ffff800100200000 || size 0000000001000000. 232285.553:0020:0024:trace:vkd3d-proton:vkd3d_address_binding_callback: BIND || VkBuffer || VA ffff800100200000 || size 0000000001000000. 232285.553:0020:0024:trace:vkd3d-proton:vkd3d_address_binding_callback: UNBIND || VkBuffer || VA ffff800100200000 || size 0000000001000000. 232285.553:0020:0024:trace:vkd3d-proton:vkd3d_address_binding_callback: UNBIND || VkDevice || VA ffff800100200000 || size 0000000001000000. ``` after: ``` % VKD3D_TEST_FILTER=create_placed_resource_size VKD3D_CONFIG=fault VKD3D_DEBUG=trace ~/src/wine/build/wine ./tests/d3d12.exe 2>&1 | grep vkd3d_address_binding_callback 232338.036:0020:0024:trace:vkd3d-proton:vkd3d_address_binding_callback: BIND || VkDevice || VA ffff800100200000 || size 0000000001000000. 232338.036:0020:0024:trace:vkd3d-proton:vkd3d_address_binding_callback: BIND || VkBuffer || VA ffff800100200000 || size 0000000001000000. 232338.037:0020:0024:trace:vkd3d-proton:vkd3d_address_binding_callback: BIND || VkImage || VA ffff800100200000 || size 000000000019a000. 232338.037:0020:0024:trace:vkd3d-proton:vkd3d_address_binding_callback: UNBIND || VkImage || VA ffff800100200000 || size 000000000019a000. 232338.037:0020:0024:trace:vkd3d-proton:vkd3d_address_binding_callback: UNBIND || VkBuffer || VA ffff800100200000 || size 0000000001000000. 232338.037:0020:0024:trace:vkd3d-proton:vkd3d_address_binding_callback: UNBIND || VkDevice || VA ffff800100200000 || size 0000000001000000. 232338.037:0020:0024:trace:vkd3d-proton:vkd3d_address_binding_callback: BIND || VkDevice || VA ffff800100200000 || size 0000000001000000. 232338.037:0020:0024:trace:vkd3d-proton:vkd3d_address_binding_callback: BIND || VkBuffer || VA ffff800100200000 || size 0000000001000000. 232338.037:0020:0024:trace:vkd3d-proton:vkd3d_address_binding_callback: UNBIND || VkBuffer || VA ffff800100200000 || size 0000000001000000. 232338.037:0020:0024:trace:vkd3d-proton:vkd3d_address_binding_callback: UNBIND || VkDevice || VA ffff800100200000 || size 0000000001000000. ``` [The spec guarantees](https://registry.khronos.org/vulkan/specs/1.3-extensions/html/v… the following: > An application can receive multiple callbacks if multiple VkDebugUtilsMessengerEXT objects are created. A callback will always be executed in the same thread as the originating Vulkan call. As of TLS I went with a suggestion from IRC: ``` <ivyl_> There's an issue with how we handle callbacks related to VK_EXT_debug_utils and VK_EXT_debug_report. In wine_vkAllocateMemory() we call device->funcs.p_vkAllocateMemory() which may execute callback. <ivyl_> At this point we still don't have handle mapping added because we don't know what host_memory handle will be. <ivyl_> AFAIU there's a spec guarantee that callback will be executed in the same thread as the call causing it, so I was thinking about maybe keeping `memory` in a tls (if enable_wrapper_list) and using that? <ivyl_> but that's I don't see any precedent of using thread local storage on the unix side <ivyl_> tls value would be short-lived in such case - only for the duration of the call to `device->funcs.p_vkAllocateMemory()` <jacekc_> we usually use teb on unix side, see ntuser_thread_info ``` -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5658

2 days, 23 hours

3
2
0 0

[PATCH v7 0/11] MR5444: jscript: Do not allocate dispex_prop_t for indexed props.

by Gabriel Ivăncescu (＠insn)

-- v7: jscript: Remove PROP_IDX dispex props by handling them in object prop methods. jscript: Move filling the PROTREF into a helper. jscript: Simplify get_flags to only check whether it's enumerable. jscript: Get rid of on_put in the object vtbl. jscript: Inline prop_put. jscript: Inline prop_get. jscript: Inline invoke_prop_func and invoke PROTREFs using their vtbl method. jscript: Inline delete_prop. jscript: Use mandatory methods in the object vtbl to operate on props found jscript: Use mandatory methods in the object vtbl to operate on props mshtml/tests: Test redefining a writable indexed prop. https://gitlab.winehq.org/wine/wine/-/merge_requests/5444

2 days, 23 hours

3
12
0 0

[PATCH 0/1] MR5657: Revert "winemac.drv: Hide app's dock icon when it wouldn't have a taskbar item on Windows."

by Tim Clem (＠tclem)

This hits some OS-level bugs, and while I think it's a valuable user experience improvement, it seems best to just revert it for now. Issues I've uncovered since it was merged: 1. Rapidly hiding and showing a dock icon results in multiple icons for the same app. Those icons persist after the app exits, and if you click on them then, they disappear. I've seen this in a few applications, most reliably the Notepad++ installer, after selecting a language in the first dialog. 2. Removing a dock icon deactivates the app and reactivates the most recently active one. If it still has windows open, those move behind whatever app becomes active. And, we can't reliably work around that because... 3. With the cooperative app activation added in Sonoma, any requests to bring forward an app with no dock icon seem to fail. One illustratively bad case is Notepad++'s in-app modal update message box. It's from another process (which gets no taskbar icon on Windows and thus no dock icon with this patch). But since it can't be brought forward, and since it's modal, the result is that the Notepad++ main window is disabled for no apparent reason, and there's no way to select the dialog. This reverts commit f0efb2e46a7fb2a00f85196a4a06bd50eda560b2. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5657

3 days

3
2
0 0

[PATCH v6 0/11] MR5444: jscript: Do not allocate dispex_prop_t for indexed props.

by Gabriel Ivăncescu (＠insn)

-- v6: jscript: Remove PROP_IDX dispex props by handling them in object prop methods. jscript: Move filling the PROTREF into a helper. jscript: Simplify get_flags to only check whether it's enumerable. jscript: Get rid of on_put in the object vtbl. jscript: Inline prop_put. jscript: Inline prop_get. jscript: Inline invoke_prop_func and invoke PROTREFs using their vtbl method. jscript: Inline delete_prop. jscript: Use mandatory methods in the object vtbl to operate on props found jscript: Use mandatory methods in the object vtbl to operate on props mshtml/tests: Test redefining a writable indexed prop. https://gitlab.winehq.org/wine/wine/-/merge_requests/5444

3 days

3
12
0 0

[PATCH 0/6] MR5656: mshtml: Use DISPEX_IDISPATCH_IMPL (part 3)

by Jacek Caban (＠jacek)

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/5656

3 days, 3 hours

3
7
0 0

[PATCH v2 0/2] MR5625: Fixes for GCC 14 warnings (in winedump)

by Aida Jonikienė (＠DodoGTA)

The `-Wstringop-overread` fix feels a bit questionable (so I'll add Eric as a reviewer to clarify the MSC structs details) -- v2: winedump: Fail on NULL funcs in dump_dir_exceptions(). winedump: Use offsetof() for string position calculations. https://gitlab.winehq.org/wine/wine/-/merge_requests/5625

3 days, 4 hours

4
3
0 0

2024

2023

2022

wine-gitlab