Kirill Smirnov : msi: Do not return success on failure (spotted by clang).

Alexandre Julliard julliard at wine.codeweavers.com
Sat May 14 10:07:27 CDT 2016


Module: wine
Branch: master
Commit: 0869852c2e08c7bbd8bd6ebbdf89e92012d8a706
URL:    http://source.winehq.org/git/wine.git/?a=commit;h=0869852c2e08c7bbd8bd6ebbdf89e92012d8a706

Author: Kirill Smirnov <kirill.k.smirnov at gmail.com>
Date:   Mon May  9 13:51:34 2016 +0300

msi: Do not return success on failure (spotted by clang).

Signed-off-by: Kirill K. Smirnov <kirill.k.smirnov at gmail.com>
Signed-off-by: Hans Leidekker <hans at codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard at winehq.org>

---

 dlls/msi/where.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/dlls/msi/where.c b/dlls/msi/where.c
index e3bc9b7..ddd8c07 100644
--- a/dlls/msi/where.c
+++ b/dlls/msi/where.c
@@ -593,7 +593,7 @@ static UINT WHERE_evaluate( MSIWHEREVIEW *wv, const UINT rows[],
 
     default:
         ERR("Invalid expression type\n");
-        break;
+        return ERROR_FUNCTION_FAILED;
     }
 
     return ERROR_SUCCESS;




More information about the wine-cvs mailing list