How are we doing?
EA Durbin
ead1234 at hotmail.com
Fri Jun 2 12:06:25 CDT 2006
>K&R style brack placements
was what i was referring to when I commented about coding style. They are an
eyesore and make things difficult to read.
>A number of people said:
> "The code is too hard to read because it's
>completely unmovitated and uncommented."
Especially the code that is responded to as , I know it's a mess to look at,
but I didn't write it.
These portions of code could use a comment or two to explain what is going
on, not every line, but explain what happens in that chunk of code.
>From: Jeremy White <jwhite at codeweavers.com>
>To: Dmitry Timoshkov <dmitry at codeweavers.com>
>CC: Mike McCormack <mike at codeweavers.com>, wine-devel at winehq.org
>Subject: Re: How are we doing?
>Date: Fri, 02 Jun 2006 11:24:06 -0500
>
> > grep Bestefich documentation/ChangeLog.ALPHA | wc -l
> > 0
> >
> > grep Bestefich ChangeLog | wc -l
> > 0
> >
>
>And this is exactly the kind of comment and attitude
>that pushes people away from being Wine developers.
>
>This was a thread that asked the question:
> What would get more developers interested in Wine?
>
>A number of people said:
> "The code is too hard to read because it's
>completely unmovitated and uncommented."
>
>Dismissing their input because they've never contributed
>code is exactly the wrong approach; if we're talking
>about getting new developers, then their impressions
>are particularly valuable.
>
>With that said, and all joking aside, I have never
>seen Alexandre reject a patch with comments or strip
>a single comment out.
>
>To get material comments in the code would require
>the imposition of a kind of standard that is far
>beyond anything we could reasonably expect.
>Heck, we can't even standardize indenting or do away
>with those abominable K&R style brack placements <g>.
>
>I just hope that the bulk of the anti comment pogrom
>is mostly posturing and jest (which is what I suspect), and that
>folks do try to comment tricky and inobvious bits.
>
>Cheers,
>
>Jeremy
>
>
More information about the wine-devel
mailing list