[PATCH 4/5] wined3d: Remove glDrawBuffer calls in BltOverride.

Alexander Dorofeyev alexd4 at inbox.lv
Tue Sep 2 08:31:20 CDT 2008

Henri Verbeet wrote:
> 2008/8/31 Alexander Dorofeyev <alexd4 at inbox.lv>:
>> Handled in ActivateContext, must be remains of pre-context management code.
>> ---
>>  dlls/wined3d/surface.c |   10 ----------
>>  1 files changed, 0 insertions(+), 10 deletions(-)
> If you're going to remove those glDrawBuffer calls, you should remove
> the buffer variable completely.

I don't think this is possible yet, the variable is also used for some 
window/screen and upside-down coordinate magic. I do suspect that the code doing 
so may need to be fixed or removed, because it looks inconsistent with code in 
e.g. ClearSurface (device.c) and doesn't seem to work correctly with windowed 
ddraw. But it probably must be done in another patch. Setting buffer for 
offscreen surface case could be removed though, as it doesn't do anything after 
removal of glDrawBuffer.

More information about the wine-devel mailing list