d3d8: Attempting to set a NULL rt is legal in d3d8

Henri Verbeet hverbeet at gmail.com
Fri Apr 22 06:57:02 CDT 2011

On 22 April 2011 13:29, Stefan Dösinger <stefan at codeweavers.com> wrote:
> We have a test. It didn't catch the problem because it tests setting both the
> depth stencil and RT to NULL, so the check if the depthstencil is NULL in
> SetRenderTarget prevented the crash. Well, I guess I can add a test for
> that...
Yeah, I wrote that test. But please add the one for a NULL rt with
non-NULL DS as well, it should be pretty trivial.

> Also the current code doesn't fail because it passes the old RT if the new RT
> is NULL. This behavior is also tested.
I meant in the sense that it would fail to set the render target to
NULL, but true, it won't actually attempt to do that.

More information about the wine-devel mailing list