d3dx9_36 [patch 1/5, try 4]: Implement D3DXSHMultiply4
Rico Schüller
kgbricola at web.de
Mon Oct 1 02:11:31 CDT 2012
On 01.10.2012 03:27, Nozomi Kodama wrote:
> I used FLOAT * WINAPI, though I don't like it.
Yeah, that's not much of an issue... and this is not the showstopper.
> + TRACE("(out %p, a %p, b %p)\n", out, a, b);
What I'm a bit curious about is, why do you reinvent a new style in a
new patch (see
http://www.winehq.org/pipermail/wine-devel/2012-September/097133.html
and
http://www.winehq.org/pipermail/wine-devel/2012-September/097131.html)?
I'm not sure if my wording is that hard to understand. For me the
preferred option for the TRACE is:
"TRACE("out %p, a %p, b %p\n", out, a, b);"
And the one also used in the file is:
"TRACE("(%p, %p, %p)\n", out, a, b);"
Please use exactly one of those. Not mixture, no extra brackets...
Sorry, I should have written an answer to the (try 3), but I wasn't fast
enough.
Cheers
Rico
More information about the wine-devel
mailing list