[PATCH 1/2] wined3d: Use the np2_fixup to find out if a RECT texture is used

[Stefan Dösinger]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Am 2013-04-12 10:34, schrieb Henri Verbeet:
> Possibly, although the only really problematic condition is the
> 1x1 texture one. If you make that go away, the condition comes down
> to ARB_texture_rectangle being supported, having a 2D texture, and
> the appropriate bit in np2_fixup being set.
I missed that one, but isn't that dead code already? 1 is a power of
2, and the code that calculates pow2_width should recognize it as
such. So there shouldn't be a 1x1 RECT texture, and thus no RECT
texture that doesn't have WINED3D_TEXTURE_POW2_MAT_IDENT set.

>> - -> GPUs that don't support ARB_texture_rectangle: Unfortunately
>> I don't have one of those, but not advertising NP2_CONDITIONAL on
>> those should be legitimate.
>> 
> Yeah, though that's also more of a generic NPOT texture cleanup,
> it's trivial to check for rect texture support in the shader code.
My prehistoric mach64 GPU might not have conditional NPOT support. If
I ever feel like messing with the empty cmos battery in that laptop
I'll install Windows again and write some tests.

> Supposedly we can't really texture from P8 anyway, and certainly
> not from shaders. I'm not sure if there's any still supported
> hardware / driver combination that supports EXT_paletted_texture
> either. We should probably just get rid of any remaining
> EXT_paletted_texture support.
I think the point of that code was to support P8 presents, and GeForce
5 and earlier cards supposedly have support for EXT_paletted_texture.

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.19 (GNU/Linux)
Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/

iQIcBAEBAgAGBQJRZ9djAAoJEN0/YqbEcdMwS+YP/jagWaMrf8TX3u4+qVwUtM8P
wsgmIdQR+AAP7tr79cA8YzCEOomH7KvtrucfNDooGiRvvMV7lsEWUEM0lPjqoQEj
NLUwZTaF0kKPOOnj6Mozf+T9acnu73Jvy4ghk1bzmvy53yHhS9DaMQ5smGavPimy
1EbS2ZG3hFJtZmDNmPlBRGJLHg4noUhGiDpbt93ztz8PtuoryTfVeq9TT/rdu0zm
7njg1kgY+Dvzyk5bSv4HxVGrrlmoY0FmFxM5u/7CjzkJCxZhqxpBuySrl7toWH4P
pgWyeWsdM4PYnbjI0JUq+dIzp6Kn0HgCqEZWNqsdUg9VE/FOS705KmJH5uVUybdG
y3peEav4PKHvgvjK9L3m1lzr8pWQUOqIuK6LiV8pC6WhM18TWTfWCnfRW4xjE1q/
a9yqKU///YX5FKYt8MHIk1/3boFN1V3pewuJ33M1oJ7Tc/D/FG8rGZlpKFXez8m+
SwgOUoGjcAWmSWnYQbSc9Gqo6hbivWZoAtbg0e78k3CjmYyK9OGpNgI6vMrfTt65
lamECLjBkVdf0O4Zgkg7Agsd6y4DtymNaEy5Kk4JwMX6OGb2EtyPYHS6sOGNmMpw
rmCKmwiYr8yU71Td058kUL6h/CjrhOCA0pa6IfbngykaRfgfFUEMWdxiLSSefdnz
q8f34ubBt3NZVidCS3UF
=WWCJ
-----END PGP SIGNATURE-----