[PATCH 1/2] wined3d: Use the np2_fixup to find out if a RECT texture is used

[Henri Verbeet]

On 12 April 2013 11:44, Stefan Dösinger <stefandoesinger at gmail.com> wrote:
> I missed that one, but isn't that dead code already? 1 is a power of
> 2, and the code that calculates pow2_width should recognize it as
> such. So there shouldn't be a 1x1 RECT texture, and thus no RECT
> texture that doesn't have WINED3D_TEXTURE_POW2_MAT_IDENT set.
>
True, so that code should go away regardless of this patch.

>> Supposedly we can't really texture from P8 anyway, and certainly
>> not from shaders. I'm not sure if there's any still supported
>> hardware / driver combination that supports EXT_paletted_texture
>> either. We should probably just get rid of any remaining
>> EXT_paletted_texture support.
> I think the point of that code was to support P8 presents, and GeForce
> 5 and earlier cards supposedly have support for EXT_paletted_texture.
>
Perhaps that was the idea for ddraw at some point, but certainly not
for d3d8 and later where you actually have shaders, since there's no
way to Present() from a texture there. As for EXT_paletted_texture
support, I don't have EXT_paletted_texture on my nv17 with Mesa, and
I'm not sure if you can really count GeForce 5 and before as
"supported" by the proprietary nvidia driver. Also note that on
GeForce 5 in particular we can do blits using shaders, and would never
want to use fixed function based blits anyway.