macdrv: implement getting and setting the screen saver state. if(Style)

Christian Costa titan.costa at gmail.com
Tue Jan 22 06:52:56 CST 2013


2013/1/22  <Joerg-Cyril.Hoehle at t-systems.com>:
> Hi,
>
> Ken Thomases wrote:
>>> +                    if(success != kIOReturnSuccess)
>>Another style nitpick: please put a space between "if" and the condition.
>>  That applies to the "if(count2)" above, too.
>
> I find this over the top.  Where is the rule?
> Andrew Eikum's mmdevapi code -- which I don't consider very old in Wine --
> uses exactly 0 space between if and ().
>
> So what is it that the Wine "project" can tell new contributors?
>
> The only rule I see is: "Look at the code surrounding the patch" and
> its corollary: "if you create a new module, you're the first and define
> the style others will have to follow."
>

Hi,

Just some stats regard "if" before Dan beat me at it ;) :
- without space => 39979
- with space => 144133

The space is better to make the distinction between C keyword and
function name. Off course it's a personal taste. :)

Bye,
Christian



More information about the wine-devel mailing list