[PATCH 1/3] kernel32: Support UTF-7 in MultiByteToWideChar. (try 2)

[Alex Henrie]

2014-10-07 13:35 GMT-06:00 Michael Stefaniuc <mstefani at redhat.com>:
> On 10/07/2014 06:06 PM, Alex Henrie wrote:
>> 2014-10-07 7:42 GMT-06:00 Alexandre Julliard <julliard at winehq.org>:
>>> Alex Henrie <alexhenrie24 at gmail.com> writes:
>>>
>>>> Sorry, I noticed a couple of errors in the utf7_mbstowcs and
>>>> utf7_wcstombs documentation. They are now corrected.
>>>
>>> You still haven't addressed the issues I mentioned last time around.
>>
>> Did you notice the long list of changes at
>> https://www.winehq.org/pipermail/wine-patches/2014-October/134808.html
>> ? A minor documentation fix was not the only improvement this time
>> around.
> You changed your patch but did you change the stuff that Alexandre wanted?

Alexandre stated that he wanted to see more tests for invalid input:
https://www.winehq.org/pipermail/wine-devel/2012-December/098051.html

The new patchset includes many more tests for invalid input, and
writing those tests exposed a bug in utf7_mbstowcs which is now fixed.
The 14 examples in test_utf7_string_conversion add 29 tests which go
through literally hundreds of code paths.

Alexandre: Please, communicate why you are rejecting the code. This
issue will drag on and on until we can come to an agreement.

-Alex