[PATCH 3/4] d3drm/tests: Replace test_Texture. (v2)
jem456.vasishta at gmail.com
Mon Apr 25 03:02:37 CDT 2016
Right, makes sense. I will resend this patch with the changes today.
Fwiw, I've intentionally not added tests in patch 4/4 to validate the image
struct in InitFromImage right now. I will include them in the
implementation patch for this function. I'll be using a helper function
which would validate the struct and return a BOOL, which would be re-used
for CreateTexture as well.
On Mon, Apr 25, 2016 at 3:21 AM, Stefan Dösinger <stefandoesinger at gmail.com>
> -----BEGIN PGP SIGNED MESSAGE-----
> Hash: SHA256
> Am 2016-04-24 um 21:49 schrieb Aaryaman Vasishta:
> > My bad, that was a copy mistake. Will resend patch.
> Even better than not checking would be to fill the array with some
> dummy value and checking that the content wasn't touched.
> I also recommend to re-order the tests so that failing tests are
> grouped together. That way you don't have to re-fill the array with a
> dummy value after a succeeding test.
> (try 2 sending this. Forgive me if it arrives twice)
> -----BEGIN PGP SIGNATURE-----
> Version: GnuPG v2
> -----END PGP SIGNATURE-----
-------------- next part --------------
An HTML attachment was scrubbed...
More information about the wine-devel