[PATCH] wined3d: Fix the size parameter of glVertexAttrib*Pointer().
Guillaume Charifi
guillaume.charifi at sfr.fr
Wed Jul 13 02:01:22 CDT 2016
Yes, you're right, don't worry, only stupid local changes with
unexpected side-effects.
But anyway, shouldn't it be more explicit to use component_count in this
case ?
Le 13/07/2016 08:28, Józef Kucia a écrit :
> On Wed, Jul 13, 2016 at 2:48 AM, Guillaume Charifi
> <guillaume.charifi at sfr.fr> wrote:
>> The mistake is obvious when looking at the GL 3.0 spec:
>> p29:
>> void VertexAttribPointer(uint index, int size, enum type, boolean normalized, sizei stride, const void *pointer);
>> void VertexAttribIPointer(uint index, int size, enum type, sizei stride, const void *pointer);
>>
>> p30:
>> Command Sizes
>> VertexAttribPointer 1, 2, 3, 4
>> VertexAttribIPointer 1, 2, 3, 4
>>
>> Signed-off-by: Guillaume Charifi <guillaume.charifi at sfr.fr>
>> ---
>> dlls/wined3d/state.c | 4 ++--
>> 1 file changed, 2 insertions(+), 2 deletions(-)
> This looks wrong to me. The "gl_vtx_format" field is equal to the
> "component_count" field. There's one exception though, the
> "gl_vtx_format" is set to GL_BGRA for WINED3DFMT_B8G8R8A8_UNORM.
> GL_BGRA was added as an accepted value by GL_ARB_vertex_array_bgra
> (core since OpenGL 3.2).
>
> What are you trying to fix?
More information about the wine-devel
mailing list