[PATCH 3/9] d3d11: Implement d3d11_immediate_context_OMGetBlendState().

Henri Verbeet hverbeet at gmail.com
Fri Jun 24 06:39:16 CDT 2016


On 24 June 2016 at 13:21, Józef Kucia <joseph.kucia at gmail.com> wrote:
> On Fri, Jun 24, 2016 at 1:07 PM, Henri Verbeet <hverbeet at gmail.com> wrote:
>> Yeah, but that's just because in most cases there's no reason to
>> expose them outside that file. E.g. impl_from_ID3D11Device() is in
>> d3d11_private.h, and in ddraw several of them are.
>
> My impression is that we want to keep them private unless there is a
> good reason to expose them. I guess my impression is mostly based on
> this comment https://www.winehq.org/pipermail/wine-devel/2015-August/108939.html.
> I can change to impl_from_ID3D11BlendState(). It doesn't make much
> different to me.

Yeah, it's a bit of a trade-off. An alternative could be to introduce
a helper function that just returns a d3d_blend_state structure.



More information about the wine-devel mailing list