[PATCH v2 1/4] d3d9/tests: Add Fetch4 tests

Fri Jan 25 10:57:02 CST 2019

Hi,

I got around to running your tests on Windows. On my Radeon HD 5770 the
texldp results match what I get on your Wine implementation. The DF16
and DF24 results differ in the green and blue channels - it seems that
this particular GPU uses "X001" for both of them. See
df24_off_evergreen.png, texldp_evergreen.png and evergreen.txt The
attached screenshots show the output with your filtering settings (mag =
linear, min = point, mip = linear).

Testing on the r500 GPU reveals that the weird 0.5 pixel offset is gone.
This is a result of the linear mag filter, the min or mip filter appear
to have no effect. I recommend to set the filters in the way AMD
mandates and continue to go for the weird 0.5 texel offset.

I don't think the difference on the r500 card is a result of clamping at
the border. The entire image is shifted, including the pixels that
sample from the center texels. See r500_ffp_point.png and r500_ffp_lin.png.

Switching to linear mag filtering obviously causes test failures in the
tests that have fetch4 off. I'll let you handle the fallout of that and
then re-run the tests on my two machines.

Maybe I'll get around to installing Windows 10 on my new Mac with an AMD
Polaris GPU. That should give some clues how the behavior developed
since then.

Stefan

Am 24.01.19 um 02:47 schrieb DarkZeros:
> If you test it, test this new set, some results are now corrected.
> 
> El mié., 23 ene. 2019 a las 1:29, DarkZeros (<mailszeros at gmail.com
> <mailto:mailszeros at gmail.com>>) escribió:
> 
>     Hi,
> 
>     Please find attached (compressed format) the set of patches,
>     Hopefully the testbot will not compile and run them.
> 
>     I would say the implementation on Wine is almost finished,
>     projection and 0.5 texel offset are working. 3D textures are not,
>     but don't work on AMD anyway.
>     I just need the values for texldp on AMD, DF16/24 in order to adjust
>     the test results expected (and maybe correct some minor deviation)
> 
>     BR,
>     Daniel
> 
>     El mar., 22 ene. 2019 a las 20:33, Stefan Dösinger
>     (<stefandoesinger at gmail.com <mailto:stefandoesinger at gmail.com>>)
>     escribió:
> 
>         Hi,
> 
>>         Am 22.01.2019 um 01:25 schrieb DarkZeros <mailszeros at gmail.com
>>         <mailto:mailszeros at gmail.com>>:
>>
>>         Hi Stefan,
>>
>>         Instead of keeping the discussion private I prefer to send it
>>         to the same thread.
>         Good idea :-)
> 
>>         I got a new file for you to test.
>>         https://www.dropbox.com/s/9a3t1j2nsy3nlm0/d3d9_crosstest.exe?dl=0 
>>
>>         I made some big mistakes on the first one (like wine and
>>         windows flags were inverted).
>>         This new one will hopefully only fail on the middle of the
>>         projection (due to rounding i will fix tomorrow), and DFXX.
>         Can you send me a diff for the tests? I have no problem
>         compiling the crosstests myself, but a compiled .exe severely
>         limits my abilities to experiment with it.
> 

-------------- next part --------------
A non-text attachment was scrubbed...
Name: df24_off_evergreen.png
Type: image/png
Size: 90416 bytes
Desc: not available
URL: <http://www.winehq.org/pipermail/wine-devel/attachments/20190125/4c5dfdd0/attachment-0004.png>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: texldp_evergreen.png
Type: image/png
Size: 7640 bytes
Desc: not available
URL: <http://www.winehq.org/pipermail/wine-devel/attachments/20190125/4c5dfdd0/attachment-0005.png>
-------------- next part --------------
visual.c:25226: Driver string: "aticfx32.dll"
visual.c:25227: Description string: "AMD Radeon HD 5700 Series"
visual.c:25230: Device name string: "\\.\DISPLAY1"
visual.c:25232: Driver version 8.17.10.1404
visual.c:15624: Test failed: Test texldp Expected color 0x1211f2f1 at (520, 30), got 0x1110f101.
visual.c:15624: Test failed: Test texldp Expected color 0x1211f2f1 at (520, 150), got 0x1110f101.
visual.c:15624: Test failed: Test texldp Expected color 0xf2f1f4f3 at (520, 270), got 0xf101f303.
visual.c:15624: Test failed: Test texldp Expected color 0x02f204f4 at (40, 390), got 0x04f42322.
visual.c:15624: Test failed: Test texldp Expected color 0x02f204f4 at (200, 390), got 0x04f42322.
visual.c:15624: Test failed: Test texldp Expected color 0xf2f1f4f3 at (360, 390), got 0xf4f32221.
visual.c:15624: Test failed: Test texldp Expected color 0xf2f1f4f3 at (520, 390), got 0xf3032120.
visual.c:15841: Test failed: Test OFF Expected color 0xfedfdfbf at (20, 15) for format DF16, got 0xff9b0000.
visual.c:15841: Test failed: Test OFF Expected color 0x9f7f7f5f at (240, 15) for format DF16, got 0xff830000.
visual.c:15841: Test failed: Test OFF Expected color 0x7f5f5f3f at (20, 240) for format DF16, got 0xff6c0000.
visual.c:15841: Test failed: Test OFF Expected color 0x5f3f3f1f at (240, 120) for format DF16, got 0xff800000.
visual.c:15841: Test failed: Test OFF Expected color 0xffdfdfbf at (20, 15) for format DF24, got 0xff9b0000.
visual.c:15841: Test failed: Test OFF Expected color 0x9f7f7f5f at (240, 15) for format DF24, got 0xff830000.
visual.c:15841: Test failed: Test OFF Expected color 0x7f5f5f3f at (20, 240) for format DF24, got 0xff6c0000.
visual.c:15841: Test failed: Test OFF Expected color 0x5f3f3f1f at (240, 120) for format DF24, got 0xff800000.
0eb4:visual: 677 tests executed (0 marked as todo, 15 failures), 0 skipped.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: r500_ffp_point.png
Type: image/png
Size: 8797 bytes
Desc: not available
URL: <http://www.winehq.org/pipermail/wine-devel/attachments/20190125/4c5dfdd0/attachment-0006.png>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: r500_ffp_lin.png
Type: image/png
Size: 6278 bytes
Desc: not available
URL: <http://www.winehq.org/pipermail/wine-devel/attachments/20190125/4c5dfdd0/attachment-0007.png>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: OpenPGP digital signature
URL: <http://www.winehq.org/pipermail/wine-devel/attachments/20190125/4c5dfdd0/attachment-0001.sig>