[PATCH 3/3] debug.h: hint a compiler: TRACE is not executed in common usage

Alexandre Julliard julliard at winehq.org
Tue Jan 29 02:01:03 CST 2019


Konstantin Kharlamov <hi-angel at yandex.ru> writes:

> On 29.01.2019 01:17, Marvin wrote:
>> Thank you for your contribution to Wine!
>>
>> This is an automated notification to let you know that your patch has
>> been reviewed and its status set to "Rejected".
>>
>> This means that the patch has been rejected by a reviewer. You should
>> have received a mail explaining why it was rejected. You need to fix
>> the issue and resend the patch, or if you are convinced that your
>> patch is good as is, you should reply to the rejection message with
>> your counterarguments.
>>
>> If you do not understand the reason for this status, disagree with our
>> assessment, or are simply not sure how to proceed next, please ask for
>> clarification by replying to this email.
>
> Hi, I don't understand, why the 3-rd patch was marked rejected? AFAIK
> it's being discussed.

I explained that such micro-optimizations won't be accepted, unless
there is clear evidence that they make a difference. Your numbers are
not convincing enough I'm afraid.

-- 
Alexandre Julliard
julliard at winehq.org



More information about the wine-devel mailing list