[PATCH v3] mshtml: Implement IHTMLDocument2 put/get_bgColor
Jacek Caban
jacek at codeweavers.com
Tue Jun 18 06:36:00 CDT 2019
Hi Alistair,
On 6/11/19 7:13 AM, Alistair Leslie-Hughes wrote:
> --- a/dlls/mshtml/htmldoc.c
> +++ b/dlls/mshtml/htmldoc.c
> @@ -680,15 +680,55 @@ static HRESULT WINAPI HTMLDocument_get_alinkColor(IHTMLDocument2 *iface, VARIANT
> static HRESULT WINAPI HTMLDocument_put_bgColor(IHTMLDocument2 *iface, VARIANT v)
> {
> HTMLDocument *This = impl_from_IHTMLDocument2(iface);
> - FIXME("(%p)->(%s)\n", This, debugstr_variant(&v));
> - return E_NOTIMPL;
> + IHTMLElement *element;
> + IHTMLBodyElement *body;
> + HRESULT hr;
> +
> + TRACE("(%p)->(%s)\n", This, debugstr_variant(&v));
> +
> + hr = IHTMLDocument2_get_body(iface, &element);
Note that get_body() may return success with NULL body (for example for
framesets). It's fine to just have FIXME for that case, but we shouldn't
crash.
Thanks,
Jacek
More information about the wine-devel
mailing list