[PATCH 1/2] dlls/d3d12: Fix D3D12SerializeVersionedRootSignature.

[Sveinar Søpler]

Ok. Tested as follows:

Wine-staging-4.20

vkd3d git HEAD at da68980fdc0e549174ce0a9c1f7859f2f388a907

World of Warcraft crashes upon loading with a "Error #132 Fatal Exception!"

Added the following patch to wine-staging-4.20: 
https://www.winehq.org/pipermail/wine-devel/2019-October/152356.html

WoW now loads, and can zone in. Textures are flashing ref. 
https://bugs.winehq.org/show_bug.cgi?id=46410

The bug: https://bugs.winehq.org/show_bug.cgi?id=47471 can be closed as 
this seems fixed with a recent commit.


To fix the texture flashing 
(https://bugs.winehq.org/show_bug.cgi?id=46410), you need this patch for 
vkd3d: 
https://www.winehq.org/pipermail/wine-devel/2019-November/153658.html , 
however due to 
https://source.winehq.org/git/vkd3d.git/commitdiff/72246862af70a338c818d9c423ce241a50bf48a4 
the patch needs a minor rework. I can post the fixed patch as a separate 
"v2" patch if it will be implemented, but since it has not been 
upstreamed so far, i dunno if it will be... Maybe better if 
Hans-Kristian Arntzen review?


Sveinar

On 16.11.2019 13:13, Sveinar Søpler wrote:
> Together with these wine patches yes, not by vkd3d patches by itself.
>
> If it is of interest, i can post the necessary vkd3d patches that 
> fixes both the errors with flashing textures 
> (https://bugs.winehq.org/show_bug.cgi?id=46410) and crashes when 
> zoning into nazjetar (https://bugs.winehq.org/show_bug.cgi?id=47471) 
> and if one or both of the "D3D12 Serialize" patches is needed for 
> D3D12 to work with current wine-staging-git?
>
> PS. This "mailinglist" thing is horribly hopeless to keep up to date 
> when referring to other patches.. atleast not in a way that i can 
> figure out other than posting links.. and browsing through various 
> .txt archive files to figure that out, so when i posted about a vkd3d 
> patch that fixed things, it was probably not clear that it ALSO needed 
> wine patches, that i think (without once again searching through 
> 100'eds of mailthreads) was mentioned earlier in the thread. Sorry.
>
> Sveinar
>
> On 15.11.2019 23:10, Henri Verbeet wrote:
>> On Sat, 16 Nov 2019 at 01:25, Sveinar Søpler <cybermax at dexter.no> wrote:
>>> I still use these two patches
>>>
>>> [PATCH 1/2] dlls/d3d12: Fix D3D12SerializeVersionedRootSignature
>>> <https://www.winehq.org/pipermail/wine-devel/2019-October/152356.html>
>>>
>>> [PATCH 2/2] dlls/d3d12: Add
>>> D3D12CreateVersionedRootSignatureDeserializer.
>>> <https://www.winehq.org/pipermail/wine-devel/2019-October/152357.html>
>>>
>>> to play World of Warcraft with my patched vkd3d. Since this seems 
>>> "gone"
>>> from the queue, does this mean it is better to try to get this
>>> implemented through staging, or should i just wait for vkd3d_1.2 and
>>> this patch being resubmitted?
>>>
>>> Kinda feel like some "special interest" to play WoW with D3D12 i 
>>> guess :)
>>>
>> I was under the impression that you said a later vkd3d patch resolved
>> the issue with World of Warcraft. Is that not the case?
>