[PATCH v2 1/2] kernel32/tests: Add tests for LCMapStringW

Fabian Maurer dark.shadow4 at web.de
Thu Feb 13 10:27:56 CST 2020


Hello Alexandre,

> It's unlikely that an app would care about the exact values. What
> matters is the sort order of different character sequences, so that's
> what you should be testing.

Sure thing, we already have some of them and I could add more later.
But since sortkeys are used for sorting, we can also test them directly. That
way it's comparatively easy to make sure we get the right comparison as well.
When a string comparison is wrong, you don't easily see why, but with sortkey
generation it's pretty clear which part is off. There's a lot that goes into a
sortkey, so I wanted to make sure all those details are also considered for
sorting. Can't hurt, right?

The compare string tests are for all windows versions. Only thing is, we could
only run those sortkey tests on win7, which is not a problem IMHO. What do you
say?

The plan was to first implement a near perfect sortkey algorithm, and them use
that to compare strings. That way we can easily implement the sortkey algo
step by step, and only switch CompareStringEx over when it's 100% working.

Regards,
Fabian Maurer





More information about the wine-devel mailing list